fix(completion-integrity): carry final verdict into learning - #28
Merged
JustinJLeopard merged 1 commit intoAug 9, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a completion-integrity gap by ensuring the learning/trajectory layer records the synthesized final run verdict (which may be downgraded by post-execution gates like intent fidelity), rather than re-deriving a potentially incorrect “success” from raw task tallies.
Changes:
- Pass
summary.statusfrom the synthesizer intolearning.record_run(..., final_status=...)so learning reflects the final verdict. - Enforce a conservative invariant in learning: only allow the defined downgrade transition (
complete→partial) whenfinal_statusdiffers from the tallied status. - Add an end-to-end regression test verifying that a fidelity-downgraded run is stored as
outcome="partial".
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_orchestrator_pipeline.py | Adds regression coverage ensuring learning stores the synthesized (downgraded) outcome. |
| justai/orchestrator.py | Threads the synthesizer’s final summary.status into learning via record_run(..., final_status=...). |
| justai/learning.py | Accepts and validates final_status (only permitting complete → partial divergence) before mapping to stored outcome. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
successwhile synthesis returnedpartialgit diff --checkSource integration only. No installation, runtime, deployment, acceptance, governance, or canonical state is changed.