fix: preserve full stage execution tally metadata - #36
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Closes the “Finding 8” observability gap by ensuring Stage 5 (“Execute”) trace metadata preserves the full, canonical ResultTally bucket breakdown while keeping the human-facing done/total done detail unchanged.
Changes:
- Update Stage 5 trace completion to emit full canonical tally metadata (
done,failed,skipped,blocked,unverified,total) sourced fromResultTally. - Keep the user-facing execution detail format identical (
{done}/{total} done) while derivingtotalfrom the same validated tally. - Add regression tests ensuring Stage 5 trace metadata includes all buckets and that the displayed detail remains compact and truthful.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
justai/orchestrator.py |
Emits complete ResultTally buckets into Stage 5 trace metadata while preserving done/total done output text. |
tests/test_completion_integrity.py |
Adds tests validating Stage 5 trace metadata contains every canonical bucket (including withheld/unverified) without changing the human detail. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contract
Close the bounded Finding 8 observability gap without changing the user-facing or Discord detail.
done/total donedone,failed,skipped,blocked,unverified, andtotalfrom the already validated canonicalResultTallyEvidence
git diff --check: PASSExact head:
01f1efb7d5f33142c254e1c949103c135f0558d5Tree:
749f399adce00d3c1cc1085eebd754b0d8a136ad