fix(reviewer): detect quoted fabricated inputs - #38
Merged
JustinJLeopard merged 1 commit intoAug 10, 2026
Merged
Conversation
Flag plans that manufacture a goal's assumed input when the shell path is quoted or follows an option terminator. This preserves the reviewer’s false-completion check for ordinary shell syntax. Co-Authored-By: OpenAI Codex <noreply@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JustinJLeopard
deleted the
justinjleopard/fix/reviewer-output-precondition
branch
August 10, 2026 04:33
There was a problem hiding this comment.
Pull request overview
This PR strengthens the heuristic reviewer’s ability to detect plans that “manufacture” (fabricate) a goal’s assumed input by expanding path-creation detection to handle quoted paths and an option terminator (--) before the created path.
Changes:
- Extend
_task_creates_pathto recognize quoted path arguments and quoted redirection paths. - Support an option terminator (
--) immediately before the created path argument in shell-like commands. - Add a regression test covering quoted fabricated input creation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
justai/reviewer.py |
Broadens the heuristic regex matching for “task creates goal-input path” to include quoting and -- terminator handling. |
tests/test_reviewer_precondition.py |
Adds a new test case intended to ensure quoted fabricated-input creation is flagged. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+45
to
+48
| tasks=[ | ||
| _task("Create source", 'touch "/data/report.csv"', "test -f /data/report.csv"), | ||
| _task("Convert it", "python convert.py /data/report.csv > /backup/report.json", | ||
| "test -s /backup/report.json", depends_on=[0]), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- flag plans that fabricate a goal input through quoted shell paths\n- recognize an option terminator before the created path\n- preserve prefix-path protection\n\n## Verification\n- ...... [100%]
6 passed in 0.01s\n- \n- independent focused review: no P0/P1 findings