change: add option to display 1.0M as 1000K#57
Open
S0yKaf wants to merge 2 commits intoJustw8:masterfrom
Open
Conversation
Contributor
|
@S0yKaf |
Author
I just cleaned up the code to be more readable and less redundant. I did not change the functionality. If the functionality did change, It wasn't my intention. so please let me know if that's the case. |
Contributor
|
@S0yKaf |
Author
|
@nanjuekaien1 I understand what I did wrong now. I fixed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a change to implement #56
I cleaned up the code a bit in the
truncateTextfunction.I also changed the behavior of
truncateLetterto be the toggle for the Million display as 1.0M versus 1000K.in short: