Open
Conversation
ce30208 to
4944a94
Compare
Owner
|
I am currently on holiday until the end of November, can you bump this PR if I forget about it come december? |
Author
|
Anyway, I'll be reworking it a bit. Avoid merging for now. Might be unrelated to this PR, but there are issues with highlight/cooldown check that need to be addressed. |
eea2592 to
a614ca3
Compare
Author
|
So to explain the recent changes:
I tried to avoid doing work such as refreshing cooldowns and refreshing highlights when the buttons are not visible, but this seems to be required for it to work. I can't think of any other side case where this stuff wouldn't work; it's a bit more verbose, but it's to ensure reliability. |
635b9d1 to
0b5235a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only thing I am missing from your addon, which is arguably the most complete teleport addon out there. So here it is.
Note that
ITEM_LOCK_CHANGEDhad to be registered early, as this event sometimes might be fired beforeOnClickandPostClickfor some reason. So I couldn't rely on click handlers to achieve that.Also
ClearAllInvalidHighlightsshould probably be renamed toRefreshHighlightsas it should take care of highlighting as well. You previously highlighted twice in the handler.Using
ZONE_CHANGED_NEW_AREAalso has the advantage of ensuring the player reequips their item if they change their mind and doesn't teleport after clicking once.