Fix seasonal filter showing TWW Raids, housing button on first login, and several bugs#188
Open
Cryzer wants to merge 1 commit intoJustw8:mainfrom
Open
Fix seasonal filter showing TWW Raids, housing button on first login, and several bugs#188Cryzer wants to merge 1 commit intoJustw8:mainfrom
Cryzer wants to merge 1 commit intoJustw8:mainfrom
Conversation
… and several bugs - Seasonal Teleports Only filter now correctly hides TWW Raids and shows Midnight - Housing button now appears on first login without needing /reload - Fixed hearthstone toy setting getting stuck after reopening the menu - Fixed random hearthstone potentially causing an infinite loop with one toy available - Fixed item filter panel showing before items finished loading - Fixed dungeon name typos: Temple of the Jade Serpent and The Everbloom in all locales - Various stability fixes: recycled button IDs, Masque nil crash, item tracking list gaps
Owner
|
Thanks for making this, I'll use what I can and apply as needed. Already fixed the leaking globals for now, but I wont use everything the AI thinks. |
Author
|
Of course, thanks for your work! I'm happy my prompts could be of use :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's fixed
Seasonal Teleports filter now correctly hides TWW Raids
With "Seasonal Teleports Only" enabled, the TWW Raids icon was still showing even though we're in the Midnight expansion. It now correctly shows only the Midnight flyout.
Housing button shows on first login without /reload
The housing teleport button would only appear after doing a manual
/reload. It now shows up correctly the first time you open the game menu after logging in.Hearthstone toy setting getting stuck
Changing your hearthstone toy in settings could sometimes get "locked in" and stop updating correctly when reopening the menu. This is now fixed.
Random hearthstone could freeze the game
In rare cases where a player had only one hearthstone toy available, the random hearthstone picker could get stuck in an infinite loop. It now handles this gracefully.
Item Filters panel loading correctly
The item filter checkboxes in the Teleport Settings panel were sometimes showing before items finished loading, causing visual issues.
Dungeon name typos fixed
"Temple of the Jade Serpent" and "The Everbloom" had a stray
lat the end of their locale keys, causing abbreviated names to not display correctly on dungeon buttons. Fixed across all locales.Various under-the-hood stability fixes
Several cases where the addon could produce Lua errors or behave unexpectedly in edge cases (recycled buttons, Masque integration, item tracking lists).
Test plan
/reload) with a housing plot — housing button should appear on first menu open