Fix CI issues and rubocop offenses by syguer · Pull Request #94 · K-and-R/email_validator

syguer · 2023-04-21T09:47:26Z

Hi ✋

I've just fixed build errors and update Rubies to latest versions.
Also, fixed rubocop offenses using -A CLI option(Auto correct).
Enjoy 😎

P.S I'm ready to be gem owner for continuous maintenance. If you want, plz give me right on Rubygems! Thanks!

syguer · 2023-04-21T09:49:35Z

email_validator.gemspec

-
-  # This gem will work with 2.4.0 or greater... but *should* work with 1.8.7+
-  s.required_ruby_version = '>= 2.4.0'
+  s.required_ruby_version = '>= 2.7.0'


activemodel requires >=2.7.0
ref: https://github.com/rails/rails/blob/main/activemodel/activemodel.gemspec#L12

This depends on the version of ActiveModel installed.

https://github.com/rails/rails/blob/3-0-stable/activemodel/activemodel.gemspec

This gem requires Ruby 2.4.

syguer · 2023-04-21T09:51:12Z

.travis.yml

+
+jobs:
+  exclude:
+  # ref: https://rubies.travis-ci.org/index.txt


Latest versions aren't supported for ppc64le.
ref: https://rubies.travis-ci.org/index.txt

It looks like they are. Where are you seeing that they are not supported?

TravisCI show all of the Rubies that we are testing. https://rubies.travis-ci.org/ They support Ruby 3.1.2 on ppc64le. I don't think that 3.2 was released when I last updated the tested Ruby versions. We should include those newer versions in testing.

I removed Ruby 2.4 form testing because it was having build issues on Travis. Though, IIRC, it would still build and test locally in my VMs.

syguer · 2023-04-21T09:54:29Z

email_validator.gemspec

    README.md
    CHANGELOG.md
  ]
-  s.files = `git ls-files -- lib/*`.split("\n")


This backquote section occurs build error on JRuby.

Is that a bug in JRuby? What does it cause a build error?

syguer · 2023-04-21T09:55:33Z

email_validator.gemspec

+  s.files = Dir['lib/**/*.rb']
  s.require_paths = %w[lib]
-
-  s.test_files = `git ls-files -- spec/*`.split("\n")


test_files is gone
ref: rubygems/guides#90

I don't think that this is correct. Please show me where test_files was removed. What commit?

syguer · 2023-04-21T09:59:32Z

email_validator.gemspec

@@ -2,8 +2,8 @@ Gem::Specification.new do |s|
  s.name = 'email_validator'
  s.version = '2.2.4'


[NOTICE]
You know, this version needs to bump up before gem push 👻

This is the current version of this gem.

I'm not sure why you are mentions this. Is there somewhere that I forgot up bump this? Did the automation fail somewhere? I don't understand why you are bringing this up.

syguer · 2023-04-24T01:44:41Z

@karlwilbur Hello 😄 Could you review this?

karlwilbur · 2023-04-24T07:22:30Z

What build errors?

We should not be removing older Ruby versions from tests since we expect that this should run successfully on those older versions.

karlwilbur · 2023-04-24T08:06:16Z

.travis.yml

-  - 2.7.0
-  - 2.7.6
-  - 3.0.1
+  - 2.7.7


We need to keep these older Ruby versions. I want to ensure that we are testing in the versions that would be used in Rails 3 projects.

I want to ensure that we are testing in the versions that would be used in Rails 3 projects.

OK

karlwilbur · 2023-04-24T08:07:45Z

.rubocop.yml

    - 'bin/*'
  NewCops: enable
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.7


We need to keep the targeted version the same as the minimum version defined in our gemspec.

karlwilbur · 2023-04-24T08:08:15Z

email_validator.gemspec

-  s.summary = 'An email validator for Rails 3+.'
-  s.description = 'An email validator for Rails 3+. See homepage for details: http://github.com/K-and-R/email_validator'
+  s.summary = 'An email validator for Rails.'
+  s.description = 'An email validator for Rails. See homepage for details: http://github.com/K-and-R/email_validator'


No. This is for "Rails 3+"

karlwilbur · 2023-04-24T08:09:15Z

spec/email_validator_spec.rb

      ]}).concat(valid_endable.map { |k, v| [
        "end-with-#{k}-#{v}@valid-characters-in-local.dev"
-      ]}).concat([
+      ]}).push(


This is fixed by rubocop.
https://docs.rubocop.org/rubocop/cops_style.html#styleconcatarrayliterals

Ah, ok. I think we'll leave it unchanged for now.

syguer · 2023-04-24T08:41:06Z

@karlwilbur Thank you for your review 😄
I didn't know You want to keep support Rails 3 so strongly... I'm so sorry.
My first motivation was to add CI against Ruby 3.2.x, so #95 looks good.
I'll close this PR and waiting for #95!
Thanks!

syguer added 2 commits April 21, 2023 18:29

Update Ruby and Rails version

5c22819

Fix cop offenses

592ed9a

syguer commented Apr 21, 2023

View reviewed changes

karlwilbur reviewed Apr 24, 2023

View reviewed changes

syguer closed this Apr 24, 2023

		@@ -2,8 +2,8 @@ Gem::Specification.new do \|s\|
		s.name = 'email_validator'
		s.version = '2.2.4'

Conversation

syguer commented Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

syguer Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

syguer commented Apr 24, 2023

Uh oh!

karlwilbur commented Apr 24, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

syguer commented Apr 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

syguer commented Apr 21, 2023 •

edited

Loading

syguer Apr 21, 2023 •

edited

Loading