Skip to content

test(ci): lint integration-tagged files and reduce test complexity#13

Merged
KARTIKrocks merged 1 commit into
mainfrom
chore/lint-integration-gocyclo
Jul 1, 2026
Merged

test(ci): lint integration-tagged files and reduce test complexity#13
KARTIKrocks merged 1 commit into
mainfrom
chore/lint-integration-gocyclo

Conversation

@KARTIKrocks

Copy link
Copy Markdown
Owner

golangci-lint, go vet, and go test skip files behind //go:build integration by default, so integration_test.go was never linted — hiding gocyclo warnings (complexity 20 > 15) in TestIntegration_BatchPublishAndClearConcurrent and TestIntegration_AnonymousQueueReconnect.

  • Pass --build-tags=integration to golangci-lint in both the Makefile and the CI lint job so integration tests are linted (and type-checked) going forward.
  • Extract reusable helpers (recvDelivery, waitForReDeclaredQueue, publishUntilDelivered, collectUniqueMessages) to bring both functions under the complexity threshold; behavior is unchanged.

Verified: lint clean in both default and integration modes; full integration suite passes against RabbitMQ 4.3.2.

Summary

Motivation

Fixes #

Changes

Checklist

  • fmt, vet, lint, test, build passes (make all)
  • New code has tests where appropriate
  • Breaking changes are documented

golangci-lint, go vet, and go test skip files behind //go:build integration by
default, so integration_test.go was never linted — hiding gocyclo warnings
(complexity 20 > 15) in TestIntegration_BatchPublishAndClearConcurrent and
TestIntegration_AnonymousQueueReconnect.

- Pass --build-tags=integration to golangci-lint in both the Makefile and the
  CI lint job so integration tests are linted (and type-checked) going forward.
- Extract reusable helpers (recvDelivery, waitForReDeclaredQueue,
  publishUntilDelivered, collectUniqueMessages) to bring both functions under
  the complexity threshold; behavior is unchanged.

Verified: lint clean in both default and integration modes; full integration
suite passes against RabbitMQ 4.3.2.
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@KARTIKrocks, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 35855142-dd60-468c-88b2-9841625c9fcc

📥 Commits

Reviewing files that changed from the base of the PR and between 9b00fa6 and d23eac3.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • Makefile
  • integration_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/lint-integration-gocyclo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KARTIKrocks
KARTIKrocks merged commit 0b82afb into main Jul 1, 2026
10 checks passed
@KARTIKrocks
KARTIKrocks deleted the chore/lint-integration-gocyclo branch July 1, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant