Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds a Vercel configuration to support client-side routing by rewriting incoming URLs to the frontend entrypoint.
Changes:
- Introduce
frontend/vercel.jsonwith a catch-all rewrite rule for SPA navigation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "rewrites": [ | ||
| { | ||
| "source": "/(.*)", | ||
| "destination": "/" | ||
| } | ||
| ] |
There was a problem hiding this comment.
The JSON formatting here is inconsistent with the rest of the repo’s JSON files (e.g., package.json uses 2-space indentation). Reformatting vercel.json with standard indentation will improve readability and reduce diff noise in future changes.
| "rewrites": [ | |
| { | |
| "source": "/(.*)", | |
| "destination": "/" | |
| } | |
| ] | |
| "rewrites": [ | |
| { | |
| "source": "/(.*)", | |
| "destination": "/" | |
| } | |
| ] |
| "rewrites": [ | ||
| { | ||
| "source": "/(.*)", | ||
| "destination": "/" |
There was a problem hiding this comment.
For an SPA fallback on Vercel, it’s typically safer/more explicit to rewrite unmatched routes to the actual entry file (e.g., /index.html) rather than "/", which relies on implicit index resolution. Consider changing the destination to the built entrypoint to avoid unexpected behavior if the hosting defaults change.
| "destination": "/" | |
| "destination": "/index.html" |
No description provided.