fix: close remaining critical SSRF alerts - #11
Conversation
|
/deepseek-review |
PR #11 第一层审查(只读,COMMENTED)结论:未发现 P0/P1 阻塞问题。 3 个 P2,集中在 P2-1 新 host 一致性校验误拒合法 IPv6 / IDN base URL(行为回归)
P2-2 新增校验分支完全无测试覆盖,回归无法被发现
P2-3 该校验不构成实际 SSRF 防线,信任边界需写明
其余核对(未发现问题的项): |
|
已处理 DeepSeek 的 3 条 P2:验证确认 Java URI 对 IPv6 返回带方括号 host,现已归一化后比较;补齐 IPv6/IDN 正向与 query/fragment 负向测试(LightRagClientTest 8/8);并在代码中明确管理员配置 + 常量 path + query 编码才是实际信任边界,双解析一致性不等同私网 allowlist。修复提交:1585676。 |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
概要
验证
此 PR 不自动合并。