Conversation
- main.ml: Parse --count N argument, pass to implementations - sender: Send N packets (default 10000) - receivers: Exit after receiving N packets (0 = infinite) Enables integration testing in CI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Run unit tests via dune runtest - Test sender startup with --count flag - Test sender/receiver communication via multicast loopback Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds integration testing capabilities to the multicast UDP project by introducing a --count parameter that allows controlling the number of packets sent/received. This enables the CI workflow to run automated tests of both sender startup and sender-receiver communication.
Changes:
- Added
--countcommand-line parameter parsing to control message count - Modified all multicast implementations (sender, async/lwt/non-concurrent receivers) to support configurable message counts
- Added integration tests to GitHub Actions CI workflow
Reviewed changes
Copilot reviewed 1 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| bin/main.ml | Added parse_count() function to parse --count argument and updated usage message |
| bin/multicast_sender.ml | Added count parameter to run function, renamed count variable to sent, set default count to 10,000 |
| bin/multicast_recv.ml | Added count and received parameters to enable receiver termination after receiving specified number of packets |
| bin/multicast_recv_lwt.ml | Added count and received parameters to Lwt-based receiver with termination logic |
| bin/multicast_recv_async.ml | Refactored make_handle_request to support count-based termination with ivar-based stopping mechanism |
| .github/workflows/ci.yml | Added unit test step and two integration tests for sender startup and sender-receiver communication |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KFoxder
commented
Jan 20, 2026
Contributor
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: KFoxder <2000316+KFoxder@users.noreply.github.com>
Use GitHub Actions timeout-minutes instead of shell timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.