Skip to content

Fix test expectation for stale sl query JSON file#342

Open
Aryan1718 wants to merge 1 commit into
Kaelio:mainfrom
Aryan1718:fix/sl-query-json-test-payload
Open

Fix test expectation for stale sl query JSON file#342
Aryan1718 wants to merge 1 commit into
Kaelio:mainfrom
Aryan1718:fix/sl-query-json-test-payload

Conversation

@Aryan1718

Copy link
Copy Markdown
Contributor

Summary

Updates the sl query JSON-file test to match the current compute.query(...) payload shape.

The implementation now sends a fuller semantic-layer payload, including dialect and resolved sources, but the test in
packages/cli/test/sl.test.ts was still asserting the older reduced shape. This caused the test to fail even though the
runtime behavior was correct.

What changed

  • Updated the runs sl query from a JSON query file assertion in packages/cli/test/sl.test.ts
  • Verified the test checks the current payload contract without duplicating lower-level policy-specific assertions

Why

This is a test-only fix. The underlying semantic-layer query path was already behaving correctly; the failure came
from an outdated expectation.

Verification

Ran:

pnpm --filter @kaelio/ktx exec vitest run test/sl.test.ts -t "runs sl query from a JSON query file" --testTimeout
30000

Result:

  • Passed

@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

@Aryan1718 is attempting to deploy a commit to the Kaelio Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant