Fix test expectation for stale sl query JSON file#342
Open
Aryan1718 wants to merge 1 commit into
Open
Conversation
|
@Aryan1718 is attempting to deploy a commit to the Kaelio Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the sl query JSON-file test to match the current compute.query(...) payload shape.
The implementation now sends a fuller semantic-layer payload, including dialect and resolved sources, but the test in
packages/cli/test/sl.test.ts was still asserting the older reduced shape. This caused the test to fail even though the
runtime behavior was correct.
What changed
Why
This is a test-only fix. The underlying semantic-layer query path was already behaving correctly; the failure came
from an outdated expectation.
Verification
Ran:
pnpm --filter @kaelio/ktx exec vitest run test/sl.test.ts -t "runs sl query from a JSON query file" --testTimeout
30000
Result: