Fix source inference for source-less aggregate measures - #354
Open
sahniaditya007 wants to merge 1 commit into
Open
Fix source inference for source-less aggregate measures#354sahniaditya007 wants to merge 1 commit into
sahniaditya007 wants to merge 1 commit into
Conversation
|
@sahniaditya007 is attempting to deploy a commit to the Kaelio Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #336
Summary
This PR adds source inference for source-less aggregate expressions in the semantic layer.
Previously, aggregate expressions without an explicit
source.columnreference (for examplecount(*),count(1), andsum(amount)) were rejected because no source could be inferred.This change infers the source when the query already determines a single unambiguous source through its dimensions and/or other measures. Queries that remain ambiguous or have no inferable source continue to raise an error with improved guidance.
Changes
count(source.pk)alternativescount(*)count(1)sum(amount))Testing