Fix three poster bugs in edititem: rematch skips poster update, TVDB cache key collision, movie poster lookup wrong path#183
Merged
Conversation
… collision, movie poster lookup uses wrong path
Copilot
AI
changed the title
Fix poster bugs: rematch doesn't update poster, TVDB cache key collision, movie poster lookup uses wrong path
Fix three poster bugs in edititem: rematch skips poster update, TVDB cache key collision, movie poster lookup wrong path
Jun 1, 2026
Copilot created this pull request from a session on behalf of
Kallb123
June 1, 2026 23:45
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the TMDB refactor, the edit-item screen has three independent poster bugs: rematching a show/movie never updates the poster image, manually selecting a different TVDB poster often silently returns the cached wrong one, and movie posters don't appear in the edit screen at all until a new poster is downloaded.
Changes
Rematch now downloads and applies the poster (
handleApplyTmdbRematch/handleApplyTvdbRematch)Both handlers updated the provider ID but explicitly skipped poster changes. Now downloads the poster from the matched result and calls
applyPosterimmediately. Failure is caught as a warning so it doesn't abort the rematch.TVDB poster cache key includes URL-derived suffix (
downloadTvdbPoster)Cache file was keyed only on TVDB series ID, so any second poster selection for the same series returned the first cached file. Key is now
{tvdbId}_{url_filename}so each distinct artwork URL gets its own file.Movie poster lookup uses
parsedPathnotpath(currentLibraryPoster)m.pathis the raw encoded SAF URI;itemKeycontains the decodedparsedPath. They never matched, so the poster always appeared blank. Changed tom.parsedPath, consistent with every other movie lookup in the file.Fix #182