Align C++ frame skipping probe logic with Python implementation #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sarah5567
reviewed
Nov 20, 2025
| buffer_ptr: int = hash(info.get_buffer()) | ||
| batch_id: int = 0 | ||
| should_process: bool = frame_skipping_probe.frame_skipping_probe(buffer_ptr, batch_id) | ||
| detector: GPUFrameChangeDetector = u_data |
Collaborator
There was a problem hiding this comment.
Consider declaring detector: GPUFrameChangeDetector directly in the function parameters instead of assigning it later.
lyuzinmaxim
reviewed
Nov 23, 2025
| stats: Dict[str, int] = {"total": 0, "skipped": 0, "processed": 0} | ||
|
|
||
| def jetson_frame_skip_probe(pad: Gst.Pad, info: Gst.PadProbeInfo, u_data: Optional[Any]) -> Gst.PadProbeReturn: | ||
| def jetson_frame_skip_probe(pad: Gst.Pad, info: Gst.PadProbeInfo, detector: GPUFrameChangeDetector) -> Gst.PadProbeReturn: |
Collaborator
There was a problem hiding this comment.
I would not have the platform name in function name - we don't gain any information from "jetson" (it can also be a cpu-based implementation, for example). I'd use gpu_frame_skip_probe or smth similar.
lyuzinmaxim
reviewed
Nov 23, 2025
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the GPU frame comparison probe logic in C++ to match the logic used in the Python implementation.
Changes include:
Closes #165