[OS-951, OS-971, OS-958] PoC Make Art chromium selenium web driver by lauraenria · Pull Request #433 · KanoComputing/make-art

lauraenria · 2019-05-03T11:36:11Z

Use Selenium web driver to test the poc make art in chromium

…/make-art into japanese_translation

Virtual page tracking with GA

…omputing/peldins/issues/2387

Changed icon background colour for Kano Apps

I18n support and Japanese translations

…eation

Rgb+rgba

Adding rgb+rgba color functions for straightforward color creation

fix gotToPlayground function

implement drawFigure for playground

implement how long the canvas is going to take take data

add module getTime improved time testing add color to console.log

change findelement with elementLocated

automate all test through challenges

delete console.log add commentes try to fix Go back home menu end challenges

benchmark and path for challenges

EGLFS

tombettany

You should reorganise this a little to have something like:

...
tests/
    auto/
        testChallenges.js
        ...
    benchmark/
        launchBenchmarks.js
        ...
    manual/
        results/
            chromium.md
            webengine.md
            ...
    utils/
        navigation.js
        ...

Also, extract the Chromium PoC code, we can't merge in the selenium stuff with it.

tombettany · 2019-05-08T09:55:31Z

selenium-webdriver/getTime.js

+module.exports = {
+  start : (el) => {
+    startTime = process.hrtime();
+    console.log(`startTime ${el} =>`.green, `${startTime[0]} s ${startTime[1]} ns`.yellow)   


Console log slows down the running of the code and interferes with the benchmark. We don't really care what time it started, we only really care about how long it takes which is printed in the end() function. If you want to log when we start timing then simply move this above the process.hrtime() and change the message to be a generic "Timer started" or something.

Ok, I delete it

tombettany · 2019-05-08T09:57:38Z

selenium-webdriver/mainSetup.js

+
+module.exports = {
+  myServer: myServer,
+  main: main


Not really the main, maybe export this as driver or something that lets us know that this is actually the driver.

I changed it as driver.

tombettany · 2019-05-08T09:58:43Z

selenium-webdriver/mainSetup.js

@@ -0,0 +1,20 @@
+const { Builder } = require('selenium-webdriver');
+
+let myServer = 'http://172.16.254.110:3000'


Hard-coded IP address. Either change this to http://127.0.0.1:3000 which will always point to the computer that you are on or don't set it and have it read from a configuration file.

I am going to use http://127.0.0.1:3000 and probably give a look from a config file.

tombettany · 2019-05-08T10:00:07Z

selenium-webdriver/mainSetup.js

+let myServer = 'http://172.16.254.110:3000'
+const chrome = require('selenium-webdriver/chrome')
+const chrome_options = new chrome.Options(); // you will need to setup Chroumium
+chrome_options.setChromeBinaryPath('/usr/bin/chromium-browser');


Right now this is only for Chromium but it might be nice in the future to have the user able to choose which browser they wish to use when the run the tests.

tombettany · 2019-05-08T10:00:37Z

selenium-webdriver/mainSetup.js

+    .setChromeOptions(chrome_options)
+
+  const driver_chr = driver_builder.build();
+  return driver_chr;


Could just

return driver_builder.build();

this was because initially there was even a Firefox option
let driver_fx = new webdriver.Builder() .forBrowser('firefox') .build();

tombettany · 2019-05-08T10:12:52Z

selenium-webdriver/canvasPerformanceGenerateData.js

+  for (let i = maxNumber; i >= 10; i = i - 10) {
+    maxNumber = i
+    let col = randomColor(colorsArray)
+    resultDraw = `color ${col}\n${figure} ${maxNumber}`


Huh?

Are we simply trying to count down from 200 in 10s? If so, this whole maxNumber bit is unnecessary:

for (let i = maxNumber; i >= 10; i -= 10) { let col = randomColor(colorsArray) resultDraw = `color ${col}\n${figure} ${i}` array.push(resultDraw) }

tombettany · 2019-05-08T10:39:53Z

README.md

+
+Follow this [Setting up your own test automation environment](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Your_own_automation_environment)
+
+- run `npm install selenium-webdriver` inside your local repo


Shouldn't be needed - npm install should grab it as it is a dependency.

ok, i modified the text

tombettany · 2019-05-08T10:40:46Z

selenium-webdriver/canvasPerformanceGenerateData.js

+];
+
+function randomColor(colorsArray) {
+  return colorsArray[Math.floor(colorsArray.length * Math.random())]


Looks like 2 space indents have been used for all this code, make it 4 to match the rest of the codebase.

tombettany · 2019-05-08T10:41:23Z

selenium-webdriver/canvasPerformanceGenerateData.js

+
+function drawFigure(colorsArray = colors, figure = 'circle') {
+  let maxNumber = 200;
+  let resultDraw = ''


Inconsistency ending lines with ; and not bothering, choose one and stick with it.

tombettany · 2019-05-08T10:46:32Z

kano_draw/draw.py

            url = base_url.format(path='')

-        self._index = url
+        self._index = 'chromium --app={url} --start-fullscreen'.format(url=url)


Split this out of this PR, we can't merge the tests and benchmarks in with this bit. It could be that you've pulled a commit from your other branch.

function and filename

add jshint 9 and semicolon, add "use strict" delete default Chromium setup

add chromium and Qtwebengine data

with Chromium

japonophile and others added 30 commits May 13, 2016 20:43

Complete translation of medium challenges

5a41d86

Start translating Pixel Hack challenges

ca47fac

Finish first translation of Pong

9f46d6b

Push japanese translations

41df993

Merge branch 'japanese_translation' of https://github.com/japonophile…

b34ccea

…/make-art into japanese_translation

Add instructions regarding translations

d787eb9

Change Pong to Pon in Japanese

60f4d48

Merge remote-tracking branch 'upstream/jessie' into jessie

173370f

Merge branch 'jessie' into japanese_translation

f5368a2

Ensure we have a path set before tracking

d301a64

Merge pull request #328 from arifshanji/virtualPageTracking

98722a3

Virtual page tracking with GA

Changed icon background colour for Kano Apps https://github.com/KanoC…

4fea9fc

…omputing/peldins/issues/2387

Merge pull request #331 from radujipa/kano-apps-colour-change

3e54c89

Changed icon background colour for Kano Apps

Merge remote-tracking branch 'upstream/jessie' into jessie

87bf19a

Merge branch 'jessie' into japanese_translation_jessie

2f9026d

Ignore locales

b9a5f8e

Return gulp stream to ensure correct timing

3a00e43

Added some tests for the i18n module

46c0dd9

Allow overriding language using query param

dc93888

Added supported language list

509f306

Fixed some formatting

2a4c0e9

Define supported locales instead of just languages

ea0e226

Merge pull request #332 from KanoComputing/i18n-ja-translations

67d24c8

I18n support and Japanese translations

adding rgb and rgba color functions for more straightforward color cr…

15e0d96

…eation

add a transparent "rgba(0,0,0,0)" color

f99da23

new ozwald boateng challenges

69c247b

fixed some validator issues

a1f1512

Merge pull request #1 from alecmolloy/rgb+rgba

5822156

Rgb+rgba

replacing tabs with spaces

aef9a06

Merge pull request #333 from alecmolloy/rgb+rgba

8e2e82c

Adding rgb+rgba color functions for straightforward color creation

lauraenria added 8 commits April 29, 2019 15:59

feat: work in progress 3

7fd6bc1

fix gotToPlayground function

feat: work in progress 4

adf5178

implement drawFigure for playground

feat:work in progress 5

5ec4763

implement how long the canvas is going to take take data

feat:work in progress

dec2dc5

add module getTime improved time testing add color to console.log

feat:work in progress 5

024e456

change findelement with elementLocated

feat: create modules

5d75707

feat: work in progreess 10

c890a2c

automate all test through challenges

feat: work in progress 11

b27b963

delete console.log add commentes try to fix Go back home menu end challenges

lauraenria requested a review from tombettany May 3, 2019 11:36

feat: delete extra space

8051826

tombettany changed the title ~~Os 951/poc make art chromium selenium web driver~~ [OS-951] PoC Make Art chromium selenium web driver May 3, 2019

lauraenria added 4 commits May 3, 2019 15:04

feat: refactoring and split in modules

55cccae

benchmark and path for challenges

docs: add data Kano-kit Chromium Benchmark

ea64c29

feat: add manual testing data

b2cae76

docs: fix info

a360ba3

EGLFS

tombettany changed the title ~~[OS-951] PoC Make Art chromium selenium web driver~~ [OS-951] PoC Make Art chromium selenium web driver May 8, 2019

tombettany changed the title ~~[OS-951] PoC Make Art chromium selenium web driver~~ [OS-951, OS-971] PoC Make Art chromium selenium web driver May 8, 2019

tombettany changed the title ~~[OS-951, OS-971] PoC Make Art chromium selenium web driver~~ [OS-951, OS-971, OS-958] PoC Make Art chromium selenium web driver May 8, 2019

tombettany requested changes May 8, 2019

View reviewed changes

paulvarache force-pushed the master branch from 952bef0 to 2f8282f Compare May 8, 2019 11:27

lauraenria added 9 commits May 8, 2019 14:57

feat:add automatic data for chromium with webdriver

31ecec2

docs: add automatic data chromium

1067d8c

feat: change name f main to driver

0a0bc04

function and filename

style: change indentation from 2 to 4 spaces

da13d00

style: fix style indentation issues

b6e07f4

add jshint 9 and semicolon, add "use strict" delete default Chromium setup

feat: update import add specific data

2ba07d5

add chromium and Qtwebengine data

feat: set option in kano kit for Chromium

21149bb

feat: add manual test in kano kit with chromium

3a71160

feat: add data CanvasHasChange on the Kanokit

80bbac4

with Chromium

		@@ -0,0 +1,20 @@
		const { Builder } = require('selenium-webdriver');

		let myServer = 'http://172.16.254.110:3000'


		Follow this [Setting up your own test automation environment](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Your_own_automation_environment)

		- run `npm install selenium-webdriver` inside your local repo

Conversation

lauraenria commented May 3, 2019

Uh oh!

tombettany left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lauraenria May 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

lauraenria May 8, 2019 •

edited

Loading