fix: prevent infinite loop in MenuBar navigation when all items disabled

[pradeep0153]

Fixes an issue where MenuBar would enter an infinite loop when selectNextMenu or selectPrevItem was triggered on a menu with entirely disabled items. The fix introduces an early return guard checking items.every(i => i.disabled). Resolves #1606.

Summary by CodeRabbit

• Bug Fixes
  • Fixed MenuBar navigation to properly handle cases where menus have no available items or all items are disabled, improving navigation responsiveness and preventing unresponsive looping behavior.

[github-actions]

Hi @pradeep0153 👋

⭐ Star this repo before your PR merges.

Why? GSSoC 2026 contributors who star get priority review and points credit. After you star, push any commit (or re-run this check). The needs-star label lifts automatically.

Thanks for your contribution to TermUI.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3cdb1513-e8f0-40b8-8ebe-d368382a12ff

📥 Commits

Reviewing files that changed from the base of the PR and between 550e9c6 and cab24be.

📒 Files selected for processing (1)

• packages/ui/src/MenuBar.ts

---

📝 Walkthrough

Walkthrough

In MenuBar.ts, the early-return guards in _selectNextItem() and _selectPrevItem() are updated to also exit when every item in the active menu is disabled, preventing an infinite loop during arrow-key navigation.

Changes

MenuBar Disabled-Item Navigation Fix

Layer / File(s)	Summary
Expand early-exit guards in navigation methods packages/ui/src/MenuBar.ts	_selectNextItem() (line 72) and _selectPrevItem() (line 87) each add a check for all items being disabled alongside the existing empty-items check, so navigation returns immediately instead of looping.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 When every door is locked and none will turn,
No need to spin in circles, that's my concern.
A quick peek down the list — all disabled, I see!
Return at once, dear loop, and set the process free.
✨ Two lines changed, a hang erased, hooray!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title accurately summarizes the main change: preventing an infinite loop in MenuBar navigation when all items are disabled.
Description check	✅ Passed	The PR description clearly states the issue, the fix mechanism, and the related issue number, though it lacks the formal template structure with sections like 'Related Issue', 'Which package(s)?', and 'Type of Change'.
Linked Issues check	✅ Passed	The code changes directly address issue #1606 by introducing early-return guards that check for all-disabled items, preventing the infinite loop in MenuBar navigation functions.
Out of Scope Changes check	✅ Passed	The changes are focused and limited to MenuBar's item navigation logic (_selectNextItem and _selectPrevItem), addressing only the infinite loop issue without introducing unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🎉 Thanks for your first PR to TermUI, @pradeep0153.

Before your PR merges:

1. ⭐ Star the repo. Required. The star-check job blocks your merge otherwise.
2. ✅ All checks green: build, test, typecheck.
3. 🏷 PR title follows type: short description. Example: fix: handle empty list.
4. 🔗 Link your closing issue in the description.

GSSoC 2026 points come from labels after merge:

• gssoc:approved. +50 base points.
• level:beginner / intermediate / advanced / critical. +20 / +35 / +55 / +80.
• quality:clean / exceptional. x 1.2 / x 1.5.
• type:*. Stackable bonus.

Your reviewer responds within 48 hours. Ping @Karanjot786 on Discord for urgent help.

🚀 Welcome to the cohort.