fix(core): reset _isRenderPending on dirty-check early return

[ionfwsrijan]

Description

In requestRender(), the deferred callback early-returns when the widget tree and layers are both clean (line 368-369) but bypasses the finally block that resets _isRenderPending to false. Once hit, _isRenderPending stays true forever, causing every subsequent requestRender() to bail out at the guard — the UI freezes permanently.

Fix

Added this._isRenderPending = false; before the early return on the clean-tree path, ensuring the guard flag is always released.

Test

Added requestRender schedules new callback after clean-tree early return — verifies that after a clean-tree render pass, a subsequent requestRender() with dirty widgets still triggers rendering.

Closes #1626

Summary by CodeRabbit

• Bug Fixes

  • Fixed an issue where rendering updates could be permanently skipped in certain application states.

• Tests

  • Added integration test verifying correct render request handling when the widget tree is in a clean state.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 349aedf2-b720-4282-aaae-f9b2f6470782

📥 Commits

Reviewing files that changed from the base of the PR and between 4b874c0 and 6d7e56e.

📒 Files selected for processing (2)

• packages/core/src/app/App.test.ts
• packages/core/src/app/App.ts

 __________________________________________________________________________
< Your code is like a magic trick: now you see it... now it's `undefined`. >
 --------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{}

[ionfwsrijan]

@Karanjot786 Please review this