Skip to content

SSPF-3301: Kargo Adapter: use gppString for GPP consent (fix Prebid API)#65

Open
nickllerandi wants to merge 2 commits intomasterfrom
codex-kargo-gpp-consent-string-fix
Open

SSPF-3301: Kargo Adapter: use gppString for GPP consent (fix Prebid API)#65
nickllerandi wants to merge 2 commits intomasterfrom
codex-kargo-gpp-consent-string-fix

Conversation

@nickllerandi
Copy link
Copy Markdown

@nickllerandi nickllerandi commented Mar 17, 2026

https://docs.prebid.org/dev-docs/modules/consentManagementGpp.html#bidder-adapter-gpp-integration

image

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

Summary by CodeRabbit

  • Bug Fixes

    • Updated GPP (Global Privacy Platform) consent data field references to ensure accurate consent information processing and validation across consent-related operations.
  • Tests

    • Revised test cases to align with updated consent data field naming conventions.

@nickllerandi nickllerandi added the bug Bug found in the production environment label Mar 17, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 17, 2026

Walkthrough

This change updates the GPP (Global Privacy Platform) consent field property naming from consentString to gppString in the Kargo bid adapter module and corresponding test suite. The logic and functionality remain unchanged; only the property references are updated.

Changes

Cohort / File(s) Summary
GPP consent field refactoring
modules/kargoBidAdapter.js
Updated getUserSyncs and getUserIds methods to reference gppString instead of consentString when accessing GPP consent data.
Test updates
test/spec/modules/kargoBidAdapter_spec.js
Updated test cases to reflect the property name change from consentString to gppString in test data and expected outputs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the Kargo Adapter to use gppString instead of consentString for GPP consent handling, which directly aligns with the file changes in both the adapter and test files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex-kargo-gpp-consent-string-fix
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

@nickllerandi nickllerandi changed the title Kargo Adapter: use gppString for GPP consent (fix Prebid API) SSPF-3301: Kargo Adapter: use gppString for GPP consent (fix Prebid API) Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug found in the production environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant