Fix: Resolve modules paths relative to project root#6
Open
fastfedora wants to merge 2 commits intoKarthikShivasankar:mainfrom
Open
Fix: Resolve modules paths relative to project root#6fastfedora wants to merge 2 commits intoKarthikShivasankar:mainfrom
fastfedora wants to merge 2 commits intoKarthikShivasankar:mainfrom
Conversation
Trailing spaces mess up diffs, so my editor is configured to remove them upon saving. To ensure good clean diffs in the commits that change the code of this project, this commit removes trailing spaces, mostly from blank lines but also from some code lines.
Modules were being resolved relative to each file's grandparent directory, causing the same file to appear under different module names (e.g., 'auth' vs 'workspace.auth'). This led to false positives in scattered functionality detection where imported functions were counted as local definitions. This commit adds `_find_project_root` to detect the actual project root by scanning upwards for project indicators (pyproject.toml, setup.py, etc.) and resolves all module names relative to this consistent root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modules were being resolved relative to each file's grandparent directory, causing the same file to appear under different module names (e.g., 'auth' vs 'workspace.auth'). This led to false positives in scattered functionality detection where imported functions were counted as local definitions.
This PR adds _find_project_root to detect the actual project root by scanning upwards for project indicators (pyproject.toml, setup.py, etc.) and resolves all module names relative to this consistent root.