Drop support for multiple output validators + move test case execution from verifyproblem to a new module#410
Merged
Conversation
Multiple output validators were technically allowed in legacy, but were never supported by Kattis. They were likely not used elsewhere either. Problemtools had some support, but it was never properly finished. As the standard has moved to only allowing a single output validator for new versions, we drop support here.
pehrsoderman
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR is a bit too large, but I failed to come up with a better way to do this, or a smaller one that made sense to me. Trying to clean up a tangled mess of code spread over 2200+ lines in one file makes for messy PR:s. Who could have guessed? :)
Moves the code to run a single test case out of verifyproblem and into a new module,
problemtools.judgewhich will eventually own the logic for judging a submission (for the purposes of problemtools usage when checking a problem package).While moving the code, I decided to take the opportunity to drop support for multiple output validators. Multiple validators were (partially) specified in legacy, but never supported in Kattis. Problemtools had some support, but it was incomplete. I doubt many problem packages ever used this. It was a bit unfortunate to add a behavioral change like this to this PR, but I felt it was preferable to wasting time moving code that would then be immediately thrown away in a follow up.
Progress on #398