Conversation
|
|
||
| # Compile Commands | ||
| *compile_commands.json | ||
| .cache/ |
There was a problem hiding this comment.
Added this for CCLS compilation databases
| * \param[in] distance The distance from the cylinder to place the regions. | ||
| * \param[in] depth The depth of boxes to create. | ||
| * \param[in] n The number of regions to create. | ||
| /** \brief Adds a set of regions to grasp a cylinder from the side. This function assumes the |
There was a problem hiding this comment.
These diffs are from my clang formatter. I'm using the lab clang-format file, it just didn't like the long lines.
There was a problem hiding this comment.
As long as it passes the check it's fine.
zkingston
left a comment
zkingston
left a comment
There was a problem hiding this comment.
Small API changes but otherwise good.
| * \param[in] position The joint value to constrain to. | ||
| * \param[in] tolerances A 2D vector of the upper bound and lower bound from \a position. | ||
| */ | ||
| void addJointConstraintToGoal(int goal_idx, const std::string &joint_name, float position, |
There was a problem hiding this comment.
Use std::size_t for all counting variables, and use double for all numbers.
There was a problem hiding this comment.
I'd also move the goal index to the last argument and make it optional, defaulting to 0 for ease of use. Similarly, I'd add a default value to the tolerances of +/- epsilon.
| * \param[in] goal_idx The index of the goal region to add this joint constraint to. | ||
| * \param[in] joint_constraint The MoveIt! joint constraint to add. | ||
| */ | ||
| void addJointConstraintToGoal(int goal_idx, moveit_msgs::JointConstraint joint_constraint); |
There was a problem hiding this comment.
Should the message be const &?
| * \param[in] distance The distance from the cylinder to place the regions. | ||
| * \param[in] depth The depth of boxes to create. | ||
| * \param[in] n The number of regions to create. | ||
| /** \brief Adds a set of regions to grasp a cylinder from the side. This function assumes the |
There was a problem hiding this comment.
As long as it passes the check it's fine.
| * \param[in] tolerances A vector of upper bound and lower bound offsets from position. | ||
| * \return The joint constraint as a MoveIt message. | ||
| */ | ||
| moveit_msgs::JointConstraint getJointConstraint(const std::string &joint_name, float position, |
2 participants
Added methods to add joint constraints to a goal region for a MotionRequestBuilder.