feature: apply clang-format to PRs before merge#296
Open
wbthomason wants to merge 1 commit intomasterfrom
Open
feature: apply clang-format to PRs before merge#296wbthomason wants to merge 1 commit intomasterfrom
wbthomason wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to add a new Github workflow that should apply
clang-formatin-place to commits in PRs. The idea is that this lets us automatically apply formatting while still allowing a chance to fix weird formatting issues before merging.Note that, because this PR is a workflow for PRs, it isn't tested yet, and may need tweaking.