Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may be a controversial PR - it's meant to allow use of
robowflex_dartwith C++20 projects, and potentially outside ofROS/catkincontexts.Currently, it does so by adding the
ROBOWFLEX_DART_ONLYcompile definition, and using this to gate the features inrobowflex::darts::Robotthat use parts of MoveIt that are incompatible with C++20.This suffices to allow C++20 projects that use only the rest of
robowflex_dartto build.However, this may be incomplete (i.e., there could be other parts of
robowflex_dartthat also need this gating applied), and it may not be the best way to achieve C++20 compatibility.I have also not tested this for building outside of
catkinyet.Thoughts?