use late static binding for RedisExtension::fixClientConfig()

[mkoubik]

...so you can actually override it

[enumag]

👎 It seems hacky. Why do you need to override it? Maybe we can find a better solution for your use-case.

[mkoubik]

I've overriden loadNativeSessionHandler() method so it resolves host and port in runtime, not in compile time.
Original extension has $savePath = sprintf('tcp://%s:%d', $session['host'], $session['port']); - it resolves the save path once and hard-codes it into the container.
In my case, host and port parameters are being resolved dynamically in runtime, so $session['host'] is a DI\Statement and thus i have $savePath = new Statement('::sprintf', ['tcp://%s:%s', $host, $port]);.

[enumag]

In that case maybe it would be enough to change fixClientConfig to ignore Statement values?

[mkoubik]

Unfortunately not, because I cannot pass instance of Statement to sprintf() (and it would make no sense), I need to create a new Statement.

[enumag]

Well you'll still need to implement loadNativeSessionHandler on your own. But why do you need to override fixClientConfig as well? What would your implementation of fixClientConfig look like?

[mkoubik]

Because of $config['host'] instanceof Statement, original fixClientConfig() assumes $config['host'] is a string.

[enumag]

Would this work for you? enumag@fe6b9ac

[mkoubik]

Yes, it would be great.