This repository was archived by the owner on Jan 6, 2022. It is now read-only.

Warning cleanup#521

Open

sebeksd wants to merge 23 commits into

KeenSoftwareHouse:masterfrom

sebeksd:Warning_cleanup

Commits on May 1, 2016

Removed unnecessary "usings"
sebeksd
committed
Remove unused exception variables
sebeksd
committed
Removed warning about hiding parent class member, this commit should be reviewed.
sebeksd
committed
Cleanup method overriding and hiding
sebeksd
committed
Removed unnecessary "break" statement
sebeksd
committed
Removed unused variables and fields
sebeksd
committed
Set correct value for creating MyProfilerBlock pool
sebeksd
committed
Removed unused variables and fields (this time with values set to them)
sebeksd
committed
Removed "Unreachable code detected" for debug code. It's not pretty but hey, it for debug only
sebeksd
committed
Removed unused variables (but with values)
sebeksd
committed
Removed false code never or always executed, this commit should be reviewed
sebeksd
committed
Added GetHashCode where it was missing (CS0661)
sebeksd
committed
Added Equals where it was missing (CS0660)
sebeksd
committed
Removed incorrect default values (CS1066)
sebeksd
committed
GetHashCode for MyToolbarItemDefinition is sealed but Equals was overrided, removed overrided version of Equals and merge it to base class, this commit should be reviewed
sebeksd
committed
Corrected Pack64() calculation for negative x/y/z values and removed warning (CS0675), this commit should be reviewed
sebeksd
committed
Removed warning for "Unreachable code detected" (CS0162) for probably a debug code, this commit should be reviewed
sebeksd
committed
Fixed planet distance calculation, removed warning "Possible mistaken empty statement" (CS0642), this commit should be reviewed
sebeksd
committed
Removed warnings about never assigned value (CS0649), some was releated to "GPU" structs or similar "fixed" size types, some was because debug code.
sebeksd
committed
Commented out some unused (debug) code
sebeksd
committed
MyMeshMaterialId moved to different file, added missing methods after rebase
sebeksd
committed
Last change after updating source code from main repo. Removed warning about hiding parent method (made it virtual)
sebeksd
committed

Commits on May 3, 2016

Fix to one of my commits overriding GetHashCode (GetHashCode full implementation for serializable object)
sebeksd
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Warning cleanup#521

Warning cleanup#521
sebeksd wants to merge 23 commits into
KeenSoftwareHouse:masterfrom
sebeksd:Warning_cleanup

Commits on May 1, 2016

Removed unnecessary "usings"

Remove unused exception variables

Removed warning about hiding parent class member, this commit should be reviewed.

Cleanup method overriding and hiding

Removed unnecessary "break" statement

Removed unused variables and fields

Set correct value for creating MyProfilerBlock pool

Removed unused variables and fields (this time with values set to them)

Removed "Unreachable code detected" for debug code. It's not pretty but hey, it for debug only

Removed unused variables (but with values)

Removed false code never or always executed, this commit should be reviewed

Added GetHashCode where it was missing (CS0661)

Added Equals where it was missing (CS0660)

Removed incorrect default values (CS1066)

GetHashCode for MyToolbarItemDefinition is sealed but Equals was overrided, removed overrided version of Equals and merge it to base class, this commit should be reviewed

Corrected Pack64() calculation for negative x/y/z values and removed warning (CS0675), this commit should be reviewed

Removed warning for "Unreachable code detected" (CS0162) for probably a debug code, this commit should be reviewed

Fixed planet distance calculation, removed warning "Possible mistaken empty statement" (CS0642), this commit should be reviewed

Removed warnings about never assigned value (CS0649), some was releated to "GPU" structs or similar "fixed" size types, some was because debug code.

Commented out some unused (debug) code

MyMeshMaterialId moved to different file, added missing methods after rebase

Last change after updating source code from main repo. Removed warning about hiding parent method (made it virtual)

Commits on May 3, 2016

Fix to one of my commits overriding GetHashCode (GetHashCode full implementation for serializable object)