Skip to content

Fix duplicate warnings in commands #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sk-keeper merged 1 commit into from
Mar 16, 2026
Merged

Fix duplicate warnings in commands #1867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion keepercommander/commands/enterprise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,7 +1201,7 @@ def execute(self, params, **kwargs):
logging.warning('Node \'%s\' already exists: Skipping.', node['data'].get('displayname'))

if not unmatched_nodes:
raise CommandError('enterprise-node', 'No nodes to add.')
return

if parent_id is None:
for node in params.enterprise['nodes']:
Expand Down
6 changes: 6 additions & 0 deletions keepercommander/commands/msp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,12 @@ def execute(self, params, **kwargs):
seats = 2147483647

name = kwargs['name']
managed_companies = params.enterprise.get('managed_companies', [])
existing_mc = get_mc_by_name_or_id(managed_companies, name)
if existing_mc:
logging.warning('Managed company \'%s\' already exists: Skipping', name)
return

tree_key = utils.generate_aes_key()
rq = {
'command': 'enterprise_registration_by_msp',
Expand Down
Loading