Conversation
The SSRF guard merged with KEEP-603 defaults to shadow mode unless
process.env.SAFE_FETCH_ENFORCE === "true" (strict string match). The
production keeperhub-common pod has no SAFE_FETCH_ENFORCE env entry,
confirmed by inspecting the live pod manifest in techops-prod. As a
result, an outbound HTTP request to 169.254.169.254 from a workflow's
HTTP Request step reaches AWS IMDS in production and returns a 401
(IMDSv2 token challenge) instead of being blocked.
Adds SAFE_FETCH_ENFORCE: "true" to:
- deploy/keeperhub/prod/values.yaml (closes the immediate prod gap)
- deploy/executor/staging/values.yaml (silent gap - workflow HTTP
steps run in the executor and
this was not enforcing today)
- deploy/executor/prod/values.yaml (same gap on prod side)
Staging keeperhub already has the entry; no change there. The value is
quoted so the rendered env stays exactly the string "true", which is
what isShadowMode() checks for via strict equality.
Out of scope (separate follow-up): lib/sandbox/child-source.ts has a
ported copy of the guard with its own configuration surface; the
keeperhub-sandbox deployment is not touched by this change.
hotfix: set SAFE_FETCH_ENFORCE in prod and executor Helm values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.