Conversation
…nt scans - listTrulyFailedNodes now counts For Each iteration-body failures, so a genuinely failed loop is no longer reconciled to success at finalization - For Each node fails (run errors) when an iteration body fails, instead of silently reporting success - recover a completed-but-abandoned body step from the success authority and continue downstream rather than dropping the rest of the iteration - query-events retries each batch with failover + backoff so a transient RPC timeout on a long scan does not fail the whole node - add executor logs for iteration failure and recovery paths
…tests - listTrulyFailedNodes treated rows with absent (undefined) loop fields as iteration rows, dropping genuinely failed top-level nodes and wrongly firing the spurious error->success override (broke the logging reconciliation integration tests). Guard for undefined as well as null. - extract computeTrulyFailedNodes into a pure, dependency-free helper and unit test it (top-level + For Each iteration recovery / sibling cases) - extract queryBatchWithRetry into query-events-core (sanctioned -core pattern) and unit test the retry + backoff behavior
…-status fix(workflow): fail loop runs on iteration errors and harden long event scans
joelorzet
requested review from
a team,
OleksandrUA,
eskp and
suisuss
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.