Conversation
- processCodeTemplates scans the code in a single pass and skips {{...}} refs
inside // line comments, /* */ and /** */ (JSDoc) block comments, and
commented-out code, so documentation/example refs no longer fail strict
resolution and abort the node
- attach the rendered code after the leftover-literal assert so commented refs
left intact are not re-flagged as unresolved
- include the line number in unresolved-ref errors (a ref can repeat in a node)
- thorough tests: every comment style x both ref forms, interleaved real and
commented code, and refs inside all common JS structures (if/switch/for/
while/do-while/for-of/for-in/ternary/object/array/class/async/generator/
IIFE/labeled/try)
A Condition inside a For Each loop that references a node on a not-taken branch (a convergence node) threw "references node ... but no output was found": the body's executeActionStep did not pass nodeMap + executionResults, so the existing dead-branch grace (resolve a never-executed node ref to undefined) could not fire. Top-level conditions already pass that context; mirror it in the body so a loop-body Condition resolves the absent ref to undefined and its doesNotExist / === undefined rules evaluate instead of failing closed.
fix(workflow): ignore template refs inside code-node comments
…anch-grace fix(workflow): give For Each body conditions the dead-branch grace
joelorzet
requested review from
a team,
OleksandrUA,
eskp and
suisuss
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.