Conversation
…ting code Anonymous better-auth accounts could mint mcp:write OAuth tokens and call the execution endpoints to run sandboxed code plus outbound HTTP, all unauthenticated and unmetered. Refuse OAuth consent for anonymous principals so no mcp token is ever issued, reject anonymous subjects in the OAuth-token and API-key resolvers so any existing credential is neutralized, and block the browser-session path on the workflow execute route. Anonymous users keep browse and build access but cannot run.
- Return 403 (not generic 401) for anonymous principals at the direct execution routes by surfacing the resolver status through validateApiKey. - Carry isAnonymous on DualAuthContext (computed from the already-loaded session) instead of an extra per-execution user lookup; drop the now unused isAnonymousUserId helper. - Drop ticket ids from the new code comments.
The /sign-in/anonymous endpoint previously fell through to the loose /* default, leaving unbounded anonymous account and org creation. Add a per-IP customRule mirroring the signup gate so anonymous session minting is throttled to 5/hour, with the same E2E bypass and CF-Connecting-IP source.
…tion fix(security): block anonymous accounts from minting tokens and executing code
joelorzet
requested review from
a team,
OleksandrUA,
eskp and
suisuss
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.