chore: remove dead Pimlico env vars and references#1598
Merged
Conversation
Gas sponsorship runs through Turnkey's native Gas Station, not Pimlico/ERC-4337. PIMLICO_API_KEY and PIMLICO_BASE_URL were provisioned but never read by any sponsorship code path. - Drop both vars from the runner system env list and the k8s job secret slug map - Remove the parameterStore entries from the PR-environment values template - Correct the .env.example gas sponsorship comment to reference Turnkey
joelorzet
requested review from
a team,
OleksandrUA,
eskp and
suisuss
and removed request for
a team
🧹 PR Environment Cleaned UpThe PR environment has been successfully deleted. Deleted Resources:
All resources have been cleaned up and will no longer incur costs. |
ℹ️ No PR Environment to Clean UpNo PR environment was found for this PR. This is expected if:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gas sponsorship runs entirely through Turnkey's native Gas Station (
ethSendTransactionwithsponsor: true), not Pimlico / ERC-4337. ThePIMLICO_API_KEYandPIMLICO_BASE_URLenv vars were provisioned but never read by any sponsorship code path.Verified by grep: no code reads
process.env.PIMLICO_*anywhere in the repo.Changes
PIMLICO_API_KEY/PIMLICO_BASE_URLfrom the runner system env list (keeperhub-executor/runner-env.ts)keeperhub-executor/k8s-job.ts)parameterStoreentries from the PR-environment values template (deploy/pr-environment/values.template.yaml).env.examplegas sponsorship comment to reference Turnkey's native Gas StationNo functional change. Pure dead-config cleanup. The matching Parameter Store keys (
/eks/techops-staging/keeperhub/pimlico-*) can be deprovisioned separately in infra.