Skip to content

Remove Draft imports and handle missing label attributes to avoid ini…#173

Open
acsevillam wants to merge 1 commit intoKeithSloan:Mainfrom
acsevillam:Main
Open

Remove Draft imports and handle missing label attributes to avoid ini…#173
acsevillam wants to merge 1 commit intoKeithSloan:Mainfrom
acsevillam:Main

Conversation

@acsevillam
Copy link
Copy Markdown

  • Remove Draft GUI imports and Draft_ArrayTools from init_gui.py to avoid Draft toolbar initialization errors.
  • Safeguard access to _updatingLabel in GDMLfraction and GDMLcomposite using getattr/setattr.
  • Update makeLabel() in GDMLfraction and GDMLcomposite to handle missing 'ref' or 'n' properties and fall back to the existing label.

@KeithSloan
Copy link
Copy Markdown
Owner

Thanks for the pull request.

Support of Draft_Arrays is an important part of the workbench.

I am not seeing any issues with FreeCAD 1.1 on Mac OS, where are you seeing the issue?

In the past version changes in FreeCAD have required changes when importing functionality from Part workbench.
If the same now applies to Draft, I would rather make the changes than drop the function.

Happy with the other fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants