Skip to content

Kenneth austin flex - #1

Open
Kennethaustin wants to merge 8 commits into
masterfrom
kenneth-austin-flex
Open

Kenneth austin flex#1
Kennethaustin wants to merge 8 commits into
masterfrom
kenneth-austin-flex

Conversation

@Kennethaustin

Copy link
Copy Markdown
Owner

No description provided.

@Kennethaustin
Kennethaustin requested a review from LeTanque May 3, 2019 21:21

@LeTanque LeTanque left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links to images are broken (wrong src path).
Nav link doesn't work.
Nav formatting doesn't match design file.
About page formatting doesn't match design file.

Doesn't meet MVP.

Comment thread README.md
1. If you were to describe semantic HTML to the next cohort of students, what would you say?

Makes co

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean... ?

Comment thread about.html Outdated
<div>
<div class="top-img">
<img class="about-header-img" src="/img/jumbo-about.png" >
</div>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor tag src path is incorrect.
/img/...
doesn't work and is not the same as
./img/...
Which is what you want.

/img refers to the root directory. ./img refers to the current directory.

Comment thread about.html
<a href="#">Contact</a>
</footer>
</body>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bulk of this page should be wrapped in a container. Like a div or a main tag, or something.

That container should be 100% wide, max 800px, and centered.

Comment thread about.html Outdated
<button>Learn More</button>
</div>
<div id="Collab">
<img src="img/about-meeting.png" alt="strategy">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these images should be 100% wide so that they take up their parent container width, only.

@Blevs
Blevs self-requested a review May 31, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants