Conversation
nnnkit
approved these changes
Aug 19, 2019
| if (typeof x == "number" && typeof y == "number") { | ||
| return x * y; | ||
| } else { | ||
| alert("not a nuumber"); |
Collaborator
There was a problem hiding this comment.
You should be more specific in the message like Both numbers are not of number data type
|
|
||
| //my code Function Declaration | ||
|
|
||
| function multiplyTwoNumber(x = 0, y = 0) { |
Collaborator
There was a problem hiding this comment.
You should take the initial value as 1 when multiplying the numbers.
|
|
||
| //my code Function Declaration | ||
|
|
||
| function divideSecondNumber( x = 0, y = 0 ) { |
Collaborator
There was a problem hiding this comment.
The initial value should be 1 not 0 for division.
|
|
||
| //my code Function Declaration | ||
|
|
||
| function performTrueFalse( a, b) { |
Collaborator
There was a problem hiding this comment.
You can also write it like this
function performTrueFalse( a, b) {
return a < b;
}
| ```js | ||
| // your code goes here | ||
|
|
||
| (age > 18) && return true || (age >= 18) && confirm("Did parents allow you?") |
Collaborator
There was a problem hiding this comment.
You should not return when using && ||.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.