Skip to content

Fix/use tarball url from package config #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nekator wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/use tarball url from package config #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d4f589
chore: update engine to node 12
Jan 17, 2020
5af658e
fix: use tarball url from package config
Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions modules/utils/npm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,11 @@ export async function getPackageConfig(packageName, version, log) {
* Returns a stream of the tarball'd contents of the given package.
*/
export async function getPackage(packageName, version, log) {
const tarballName = isScopedPackageName(packageName)
? packageName.split('/')[1]
: packageName;
const tarballURL = `${npmRegistryURL}/${packageName}/-/${tarballName}-${version}.tgz`;
const packageConfig = getPackageConfig(packageName, version, log);
if (!packageConfig && !packageConfig.dist && !packageConfig.dist.tarball) {
return null;
}
const tarballURL = packageConfig.dist.tarball;

log.debug('Fetching package for %s from %s', packageName, tarballURL);

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,6 @@
"supertest": "^3.0.0"
},
"engines": {
"node": "10.x.x"
"node": "12.x.x"
}
}