Skip to content

Fix: IOS App Crashes when an invalid URL is loaded #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vaibhav2002 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: IOS App Crashes when an invalid URL is loaded #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 25 additions & 16 deletions webview/src/iosMain/kotlin/com/multiplatform/webview/web/IOSWebView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import kotlinx.cinterop.allocArrayOf
import kotlinx.cinterop.memScoped
import kotlinx.cinterop.useContents
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.launch
import platform.Foundation.HTTPBody
import platform.Foundation.HTTPMethod
import platform.Foundation.NSBundle
Expand Down Expand Up @@ -50,20 +51,28 @@ class IOSWebView(
url: String,
additionalHttpHeaders: Map<String, String>,
) {
val request =
NSMutableURLRequest.requestWithURL(
URL = NSURL(string = url),
)
additionalHttpHeaders.all { (key, value) ->
request.setValue(
value = value,
forHTTPHeaderField = key,
)
true
try {
val request = NSMutableURLRequest.requestWithURL(URL = NSURL(string = url))
additionalHttpHeaders.forEach { (key, value) ->
request.setValue(value = value, forHTTPHeaderField = key)
}
webView.loadRequest(request = request)
} catch (e: Exception) {
KLogger.e { "The url is not a valid web URL: $url" }
scope.launch {
val errorHtml =
"""
<!DOCTYPE html>
<html><head><title>Error</title></head>
<body>
<h1>Error Loading URL</h1>
<p>Could not load: $url</p>
<p>Error: ${e.message}</p>
</body></html>
""".trimIndent()
loadHtml(errorHtml)
}
}
webView.loadRequest(
request = request,
)
}

override suspend fun loadHtml(
Expand Down Expand Up @@ -97,7 +106,7 @@ class IOSWebView(
WebViewFileReadType.ASSET_RESOURCES -> {
val resourcePath =
(NSBundle.mainBundle.resourcePath ?: "") +
"/compose-resources/assets/" + fileName
"/compose-resources/assets/" + fileName
fileURL = NSURL.fileURLWithPath(resourcePath)

val parentDir = (resourcePath as NSString).stringByDeletingLastPathComponent()
Expand Down Expand Up @@ -131,11 +140,11 @@ class IOSWebView(
if (finalReadAccessURL.path.isNullOrEmpty()) {
KLogger.e {
"Critical: finalReadAccessURL is null or has an empty path. " +
"Cannot load file with proper read access for ${fileURL.absoluteString}"
"Cannot load file with proper read access for ${fileURL.absoluteString}"
}
loadHtml(
"<html><body>Error: Cannot determine read access URL " +
"for ${fileURL.absoluteString}</body></html>",
"for ${fileURL.absoluteString}</body></html>",
)
return
}
Expand Down
Loading