v2.2.0: Support Enrollment Patterns#44
Merged
doebrowsk merged 32 commits intoJul 14, 2025
Merged
Conversation
…nt pattern name usage
…tokens can be used for API client
…of via pagination
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the issuer to support Keyfactor Command Enrollment Patterns (by ID or name), migrates to the new keyfactor-go-client-sdk, and adds corresponding tests, documentation, and CI fixes.
- Migrated SDK import and client calls from
keyfactor-go-clienttokeyfactor-go-client-sdk/v25 - Extended
SignConfigand CRDs to acceptenrollmentPatternIdandenrollmentPatternName, plus added lookup and fallback logic - Updated tests (unit and e2e), docs, and Helm workflows to reflect enrollment patterns and fixed chart release triggers
Reviewed Changes
Copilot reviewed 22 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/command/command.go | Added fields & logic to populate EnrollmentPatternId/Name and updated client calls |
| internal/command/command_test.go | New test cases for enrollment pattern support and adjusted fixtures |
| internal/command/client.go | Extended Client interface and adapter to include GetEnrollmentPatterns |
| internal/command/command_test.go | Missing expected: true in success-all-meta test case |
| api/v1alpha1/issuer_types.go | Updated CRD struct tags and comments to deprecate certificateTemplate in favor of patterns |
| deploy/charts/.../issuers.yaml & clusterissuers.yaml | Added enrollmentPatternId and enrollmentPatternName to CRDs |
| docs/ & e2e scripts | Documentation updates for enrollment patterns; new e2e run_tests.sh |
| .github/workflows/helm.yml & keyfactor-bootstrap-workflow.yml | Fixed Helm release trigger to run on tag pushes and updated action versions |
| }, | ||
| "failure-missing-meta": { | ||
| presentMeta: []v1.CSSCMSDataModelModelsMetadataType{ | ||
| { |
There was a problem hiding this comment.
The success-all-meta test case does not set expected: true, so it will default to false and fail. Add expected: true to this case.
spbsoluble
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keyfactor-go-clienttokeyfactor-go-client-sdk.Dependency updates also address some Dependabot alerts: