Merged
Conversation
Member
narekgharibyan
left a comment
There was a problem hiding this comment.
lgtm, just seems that the newly written files will be possible to open with new versions of keyvi only ... don't remember do we have some sort of min version requirement somewhere in code ?
Contributor
Author
|
Good point! Yes, we have versioning in keyvi files. I will make use of it. It should be possible to only bump the version if Currently an old version would throw an exception the 1st time a value has to be unpacked. With versioning in place it will not be possible to open a dictionary that uses |
dd3c595 to
fbc86d1
Compare
Contributor
Author
|
added versioning, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add zstd compression support