Update test cases and golden files for HDR6x6i#64
Update test cases and golden files for HDR6x6i#64MarkCallow merged 6 commits intoKhronosGroup:mainfrom
Conversation
Can you please verify that the CLA/Assistant is properly set up because the Contributor License Agreement appears empty when I click on the link. |
MarkCallow
left a comment
There was a problem hiding this comment.
Obviously you need to rebase to current main and fix the conflicts in the extract tests. I added cases to these tests for extracting ASTC HDR when I fixed the issue. Other than that this seems fine.
As for the CLA, I don't know what is going on. There is a comment one hour before yours saying all contributors have signed. There may have been a network problem. One of the CI runs failed about the same time saying it could not contact github.com to clone the repo. Since it says "all contributors have signed", I am not going to worry about it.
Can you please clarify about rebasing with main? The e8d22c3 commit was the actual rebase with upstream/main. Is there something missing because my repo is already up to date. |
|
Files changed is showing conflicts in |
|
Ahh! I think you missed the conflict when you merged because it is present in e8d22c3 as well. |
Rename existing HDR test inputs to match template of other file names.
Wow, really messed this up. Should be good now. |
|
I am merging this with the expectation that the golden files are correct in order that only a single reference update in PR KhronosGroup/KTX-Software#1149 will be needed. |
This PR, updates test cases and regenerates golden files for
ktx createHDR6x6i cases after BasisU fixes were backported and--uastc-qualityand--uastc-hdr-6x6i-leveloption values were properly handled within the software.