Skip to content

Update test cases and golden files for HDR6x6i#64

Merged
MarkCallow merged 6 commits intoKhronosGroup:mainfrom
phasmatic3d:main
Mar 23, 2026
Merged

Update test cases and golden files for HDR6x6i#64
MarkCallow merged 6 commits intoKhronosGroup:mainfrom
phasmatic3d:main

Conversation

@ViNeek
Copy link
Copy Markdown
Collaborator

@ViNeek ViNeek commented Mar 19, 2026

This PR, updates test cases and regenerates golden files for ktx create HDR6x6i cases after BasisU fixes were backported and --uastc-quality and --uastc-hdr-6x6i-level option values were properly handled within the software.

@ViNeek ViNeek changed the title Update test cases and golden files for HDR6x6i fter BasisU fixes were backported and Update test cases and golden files for HDR6x6i Mar 19, 2026
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 19, 2026

CLA assistant check
All committers have signed the CLA.

@ViNeek
Copy link
Copy Markdown
Collaborator Author

ViNeek commented Mar 19, 2026

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.✅ agkar❌ ViNeekYou have signed the CLA already but the status is still pending? Let us recheck it.

Can you please verify that the CLA/Assistant is properly set up because the Contributor License Agreement appears empty when I click on the link.

@ViNeek ViNeek requested a review from MarkCallow March 19, 2026 17:04
Copy link
Copy Markdown
Collaborator

@MarkCallow MarkCallow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously you need to rebase to current main and fix the conflicts in the extract tests. I added cases to these tests for extracting ASTC HDR when I fixed the issue. Other than that this seems fine.

As for the CLA, I don't know what is going on. There is a comment one hour before yours saying all contributors have signed. There may have been a network problem. One of the CI runs failed about the same time saying it could not contact github.com to clone the repo. Since it says "all contributors have signed", I am not going to worry about it.

@ViNeek
Copy link
Copy Markdown
Collaborator Author

ViNeek commented Mar 20, 2026

Obviously you need to rebase to current main and fix the conflicts in the extract tests. I added cases to these tests for extracting ASTC HDR when I fixed the issue. Other than that this seems fine.

As for the CLA, I don't know what is going on. There is a comment one hour before yours saying all contributors have signed. There may have been a network problem. One of the CI runs failed about the same time saying it could not contact github.com to clone the repo. Since it says "all contributors have signed", I am not going to worry about it.

Can you please clarify about rebasing with main? The e8d22c3 commit was the actual rebase with upstream/main. Is there something missing because my repo is already up to date.

@MarkCallow
Copy link
Copy Markdown
Collaborator

Files changed is showing conflicts in tests/extract/exr_hdr_2d.json and tests/extract/exr_hdr_2d_mip.json. One arm of the conflict is that addition of the ASTC_6x6_SFLOAT_BLOCK cases which were added in cbbf4bc. From this I guessed you must not have pulled the latest from this CTS repo. If you have cbbf4bc I don't understand the conflict.

@MarkCallow
Copy link
Copy Markdown
Collaborator

Ahh! I think you missed the conflict when you merged because it is present in e8d22c3 as well.

Rename existing HDR test inputs to match template of other file names.
@ViNeek
Copy link
Copy Markdown
Collaborator Author

ViNeek commented Mar 20, 2026

Ahh! I think you missed the conflict when you merged because it is present in e8d22c3 as well.

Wow, really messed this up. Should be good now.

@MarkCallow
Copy link
Copy Markdown
Collaborator

I am merging this with the expectation that the golden files are correct in order that only a single reference update in PR KhronosGroup/KTX-Software#1149 will be needed.

@MarkCallow MarkCallow merged commit cd01293 into KhronosGroup:main Mar 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants