HDR Support for libktx and tools#1100
Conversation
|
I just reviewed the test updates again. Now I see that there are no tests of |
|
Please add a check to |
|
I am not liking having |
|
|
|
I built and installed the |
|
I have just realized that support for I am sorry that I failed to notice the omission before. |
|
Re needs a line, I think |
|
I have opened an issue for each of the newly discovered items. I will merge this because the number of comments in this PR makes dealing with any more unwieldy, and time consuming, and what is here is working. Please continue discussion on the new items in the relevant issue. |
The pull request adds initial support for HDR data in libktx and tools In particular, 1. The CLI ktx tool is updated so that: - the `ktx info` command supports **UASTC HDR** payload formats as defined in the KTX Specification. - the `ktx validate` command implements new validation clauses related to the **UASTC HDR** payload formats - the `ktx encode` command now accepts **uastc-hdr-4x4** and **uastc-hdr-6x6i** as codec strings. - These codecs require the input file format to be either **R16G16B16_SFLOAT** or **R16G16B16A16_SFLOAT**. - the `ktx create` command when the **encode** parameter is used, accepts **uastc-hdr-4x4** and **uastc-hdr-6x6i** for the **codec** parameter - if the input is raw, these codecs require the format parameter to be either **R16G16B16_SFLOAT** or **R16G16B16A16_SFLOAT**; - if the input is not raw, the input files must be EXR with half-float data type - the ktx transcode supports the two new codecs for input files: - **uastc-hdr-4x4** inputs must accept three targets: **rgba16f**, **astc-hdr-4x4**, and **bc6hu** - **uastc-hdr-6x6i** inputs must accept three targets: **rgba16f**, **astc-hdr-6x6**, and **bc6hu** - if an input file is neither of these two formats, the targets are rejected, - the `ktx extract` command supports the two new codecs for input files - **uastc-hdr-4x4** inputs may be extracted as raw, or transcoded as in `ktx transcode` - **uastc-hdr-6x6i** inputs require transcoding as in `ktx transcode` when used with this command - the `ktx compare` command, when used with **UASTC HDR 4x4** or **UASTC HDR 6x6** data and pixel comparison is requested, the image is transcoded to uncompressed half-float values prior to comparison 2. The existing JavaScript bindings is updated to support the new functionality, specifically transcoding of UASTC HDR payloads Incidentally fixes KhronosGroup#1109. --------- Co-authored-by: agkar <a.gkaravelis@gmail.com>

The pull request adds initial support for HDR data in libktx and tools
In particular,
ktx infocommand supports UASTC HDR payload formats as defined in the KTX Specification.ktx validatecommand implements new validation clauses related to the UASTC HDR payload formatsktx encodecommand now accepts uastc-hdr-4x4 and uastc-hdr-6x6i as codec strings.ktx createcommand when the encode parameter is used, accepts uastc-hdr-4x4 and uastc-hdr-6x6i for the codec parameterktx extractcommand supports the two new codecs for input filesktx transcodektx transcodewhen used with this commandktx comparecommand, when used with UASTC HDR 4x4 or UASTC HDR 6x6 data and pixel comparison is requested, the image is transcoded to uncompressed half-float values prior to comparisonIncidentally fixes #1109.