Fix validation warning for VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL c…#1148
Merged
MarkCallow merged 2 commits intomainfrom Mar 16, 2026
Merged
Fix validation warning for VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL c…#1148MarkCallow merged 2 commits intomainfrom
MarkCallow merged 2 commits intomainfrom
Conversation
- Set -Wno-experimental to disablecCompile warning that sdl3 is still experimental. - Change EMSCRIPTEN pre-processor macro to __EMSCRIPTEN__ to avoid deprecation warnings.
richgel999
pushed a commit
to BinomialLLC/KTX-Software-Binomial-Fork
that referenced
this pull request
Mar 18, 2026
KhronosGroup#1148) …ase. For the `VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL` case of `setImageLayout`, where `dstAccessMask` is `VK_ACCESS_SHADER_READ_BIT`, setting`destStageFlags` to `VK_PIPELINE_STAGE_ALL_COMMANDS_BIT` is invalid usage and is flagged by the validator in recent Vulkan SDKs. Change `dstStageFlags` for this case to `VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT | VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT`. Fixes KhronosGroup#1092. Includes completely unrelated fixes for warnings that are new in Emscripten 5.0.3 so that CI builds are successful. - Set -Wno-experimental to disable compile- and link-time warnings that sdl3 is still experimental. - Change `EMSCRIPTEN` pre-processor macro to `__EMSCRIPTEN__` to stop deprecation warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ase.
For the
VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMALcase ofsetImageLayout, wheredstAccessMaskisVK_ACCESS_SHADER_READ_BIT, settingdestStageFlagstoVK_PIPELINE_STAGE_ALL_COMMANDS_BITis invalid usage and is flagged by the validator in recent Vulkan SDKs. ChangedstStageFlagsfor this case toVK_PIPELINE_STAGE_ALL_GRAPHICS_BIT | VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT.Fixes #1092.
Includes completely unrelated fixes for warnings that are new in Emscripten 5.0.3 so that CI builds are successful.
EMSCRIPTENpre-processor macro to__EMSCRIPTEN__to stop deprecation warnings.