Closed
Conversation
Use `clSetKernelArg` to set args after kernel is cloned. Enqueue and read the buffer to validate. The test uses `buf_write_kernel` kernel program with 2 arguments. * In test_clone_kernel, if `clEnqueueReadBuffer` was a success then the error code would be `CL_SUCCESS`, which will not print the error message when buffer validation fails, therefore replace with `test_assert_error` to print the error message. * Add test coverage for `clCloneKernel` with Execinfo Use `clSetKernelExecInfo` after kernel is cloned and read the buffer to validate. The test uses the `set_kernel_exec_info_kernel` kernel program with 2 arguments. * Add test covergae for `clCloneKernel` with no args Clone a kernel with no args and enqueue. The test uses `test_kernel_empty` kernel program with no arguments. * Add test coverge for `clCloneKernel` with SVM pointer Use `clSetKernelArgSVMPointer` to set args after kernel is cloned. Enqueue and read the buffer to validate.The test uses `buf_write_kernel` kernel program with 2 arguments. Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>
Signed-off-by: John Kesapides <john.kesapides@arm.com>
Contributor
Author
|
Upstreaming on behalf of ARM |
Contributor
Author
|
rejecting. Vikas(original author) has moved on to a different project and this has been stale for a really long time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking over PR #1251.
Minor rework from last review comments on that PR