Skip to content

Added support for cl_ext_float_atomics in CBasicTestFetchMinSpecialFloats with atomic_float#2391

Merged
bashbaug merged 6 commits intoKhronosGroup:mainfrom
shajder:float_atomics_fp32_spec_min
Mar 10, 2026
Merged

Added support for cl_ext_float_atomics in CBasicTestFetchMinSpecialFloats with atomic_float#2391
bashbaug merged 6 commits intoKhronosGroup:mainfrom
shajder:float_atomics_fp32_spec_min

Conversation

@shajder
Copy link
Contributor

@shajder shajder commented May 15, 2025

Related to #2142, according to the work plan, extending CBasicTestFetchMinSpecialFloats with support for atomic_float.

@bashbaug
Copy link
Contributor

Adding "focused review" after discussion in the February 10th teleconference.

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check that this test logic is working the way you expect it to work? These tests seem to run significantly longer than the fp16 add special values tests. I found one logic error, but there might be others...

@shajder
Copy link
Contributor Author

shajder commented Feb 25, 2026

Can you check that this test logic is working the way you expect it to work? These tests seem to run significantly longer than the fp16 add special values tests. I found one logic error, but there might be others...

hmm, I just tested separate CBasicTestFetchMinSpecialFloats test. On both Intel UHD graphics and nvidia GPU devices it executes in "no time". With Intel CPU implementation I got a total freeze while starting SVM part of the test.

One thing I've noticed is worse performance of FP64 regular CBasicTestFetchMin test but it is pretty obvious due to emulation flag switched on (IGC_EnableDPEmulation)

@bashbaug
Copy link
Contributor

Merging as discussed in the March 10th teleconference.

@bashbaug bashbaug merged commit 6506421 into KhronosGroup:main Mar 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants