Skip to content

Fix left shift operator undefined behavior in integer_ops #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bashbaug merged 3 commits into from
Apr 6, 2026
+6 −2
Merged

Fix left shift operator undefined behavior in integer_ops #2627

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48cc21c
Fix left shift operator undefined behavior in integer_ops
joselopeqti Mar 3, 2026
eaf39c2
Apply clang-format
joselopeqti Mar 3, 2026
9c05908
Apply suggestion from @bashbaug
joselopeqti Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test_conformance/integer_ops/test_extended_bit_ops_insert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,12 @@ cpu_bit_insert(T tbase, T tinsert, cl_uint offset, cl_uint count)
cl_ulong base = static_cast<cl_ulong>(tbase);
cl_ulong insert = static_cast<cl_ulong>(tinsert);

cl_ulong mask = (count < 64) ? ((1ULL << count) - 1) << offset : ~0ULL;
cl_ulong result = ((insert << offset) & mask) | (base & ~mask);
cl_ulong result = base;
if (offset < 64)
{
cl_ulong mask = (count < 64) ? ((1ULL << count) - 1) << offset : ~0ULL;
result = ((insert << offset) & mask) | (base & ~mask);
}

return static_cast<typename std::make_unsigned<T>::type>(result);
}
Expand Down
Loading