Skip to content

Use clSetMemObjectDestructorCallback for CL_MEM_USE_HOST_PTR #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulfradgley wants to merge 2 commits into
base: main
Choose a base branch
from
+56 −38
Open

Use clSetMemObjectDestructorCallback for CL_MEM_USE_HOST_PTR #2628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a11211
Use clSetMemObjectDestructorCallback for CL_MEM_USE_HOST_PTR
paulfradgley Mar 3, 2026
b9e25e3
Remove extra trailing ;
paulfradgley Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 56 additions & 38 deletions test_conformance/buffers/test_buffer_read.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,11 @@ static int verify_read_struct(TestStruct *outptr, int n)
return 0;
}

static void callback_align_free(cl_mem memobj, void* userData)
{
align_free(userData);
}

//----- the test functions
static int test_buffer_read(cl_device_id deviceID, cl_context context,
cl_command_queue queue, int num_elements,
Expand Down Expand Up @@ -700,20 +705,33 @@ static int test_buffer_read(cl_device_id deviceID, cl_context context,
return -1;
}

err = clSetMemObjectDestructorCallback(buffer, callback_align_free, inptr[i]);
if (err != CL_SUCCESS)
{
print_error(err, " clCreateBuffer failed\n" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}

err = clSetMemObjectDestructorCallback(buffer, callback_align_free, outptr[i]);
if (err != CL_SUCCESS)
{
print_error(err, " clCreateBuffer failed\n" );
align_free( outptr[i] );
return -1;
}

err = clSetKernelArg(kernel[i], 0, sizeof(cl_mem), (void *)&buffer);
if ( err != CL_SUCCESS ){
print_error( err, "clSetKernelArg failed" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}

err = clEnqueueNDRangeKernel(queue, kernel[i], 1, NULL,
global_work_size, NULL, 0, NULL, NULL);
if ( err != CL_SUCCESS ){
print_error( err, "clEnqueueNDRangeKernel failed" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}

Expand All @@ -722,8 +740,6 @@ static int test_buffer_read(cl_device_id deviceID, cl_context context,
NULL, NULL);
if ( err != CL_SUCCESS ){
print_error( err, "clEnqueueReadBuffer failed" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}

Expand All @@ -743,8 +759,6 @@ static int test_buffer_read(cl_device_id deviceID, cl_context context,
if (err != CL_SUCCESS)
{
print_error( err, "clEnqueueReadBuffer failed" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}

Expand All @@ -755,11 +769,6 @@ static int test_buffer_read(cl_device_id deviceID, cl_context context,
else{
log_info( " %s%d test passed in-place readback\n", type, 1<<i );
}


// cleanup
align_free( outptr[i] );
align_free( inptr[i] );
}
} // mem flag

Expand Down Expand Up @@ -851,19 +860,32 @@ static int test_buffer_read_async(cl_device_id deviceID, cl_context context,
return -1;
}

err = clSetMemObjectDestructorCallback(buffer, callback_align_free, inptr[i]);
if (err != CL_SUCCESS)
{
print_error(err, " clCreateBuffer failed\n" );
Copy link
Copy Markdown

@Kerilk Kerilk Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste error.

Suggested change
print_error(err, " clCreateBuffer failed\n" );
print_error(err, " clSetMemObjectDestructorCallback failed\n" );

Copy link
Copy Markdown

@Kerilk Kerilk Mar 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears 6 times

align_free( outptr[i] );
align_free( inptr[i] );
return -1;
Comment thread
Kerilk marked this conversation as resolved.
}

err = clSetMemObjectDestructorCallback(buffer, callback_align_free, outptr[i]);
if (err != CL_SUCCESS)
{
print_error(err, " clCreateBuffer failed\n" );
Comment thread
Kerilk marked this conversation as resolved.
align_free( outptr[i] );
return -1;
}

err = clSetKernelArg(kernel[i], 0, sizeof(cl_mem), (void *)&buffer);
if ( err != CL_SUCCESS ){
print_error( err, "clSetKernelArg failed" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}

err = clEnqueueNDRangeKernel( queue, kernel[i], 1, NULL, global_work_size, NULL, 0, NULL, NULL );
if ( err != CL_SUCCESS ){
print_error( err, "clEnqueueNDRangeKernel failed" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}

Expand All @@ -879,15 +901,11 @@ static int test_buffer_read_async(cl_device_id deviceID, cl_context context,
#endif
if ( err != CL_SUCCESS ){
print_error( err, "clEnqueueReadBuffer failed" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}
err = clWaitForEvents(1, &event );
if ( err != CL_SUCCESS ){
print_error( err, "clWaitForEvents() failed" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}

Expand All @@ -900,10 +918,6 @@ static int test_buffer_read_async(cl_device_id deviceID, cl_context context,
log_info(" %s%d test passed. cl_mem_flags src: %s\n", type,
1 << i, flag_set_names[src_flag_id]);
}

// cleanup
align_free( outptr[i] );
align_free( inptr[i] );
}
} // mem flags

Expand Down Expand Up @@ -993,19 +1007,32 @@ static int test_buffer_read_array_barrier(
return -1;
}

err = clSetMemObjectDestructorCallback(buffer, callback_align_free, inptr[i]);
if (err != CL_SUCCESS)
{
print_error(err, " clCreateBuffer failed\n" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}

err = clSetMemObjectDestructorCallback(buffer, callback_align_free, outptr[i]);
if (err != CL_SUCCESS)
{
print_error(err, " clCreateBuffer failed\n" );
align_free( outptr[i] );
return -1;
}

err = clSetKernelArg(kernel[i], 0, sizeof(cl_mem), (void *)&buffer);
if ( err != CL_SUCCESS ){
print_error( err, "clSetKernelArgs failed" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}

err = clEnqueueNDRangeKernel( queue, kernel[i], 1, NULL, global_work_size, NULL, 0, NULL, NULL );
if ( err != CL_SUCCESS ){
print_error( err, "clEnqueueNDRangeKernel failed" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}

Expand All @@ -1021,22 +1048,17 @@ static int test_buffer_read_array_barrier(
#endif
if ( err != CL_SUCCESS ){
print_error( err, "clEnqueueReadBuffer failed" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}
err = clEnqueueBarrierWithWaitList(queue, 0, NULL, NULL);
if ( err != CL_SUCCESS ){
print_error( err, "clEnqueueBarrierWithWaitList() failed" );
align_free( outptr[i] );
return -1;
}

err = clWaitForEvents(1, &event);
if ( err != CL_SUCCESS ){
print_error( err, "clWaitForEvents() failed" );
align_free( outptr[i] );
align_free( inptr[i] );
return -1;
}

Expand All @@ -1049,10 +1071,6 @@ static int test_buffer_read_array_barrier(
log_info(" %s%d test passed. cl_mem_flags src: %s\n", type,
1 << i, flag_set_names[src_flag_id]);
}

// cleanup
align_free( outptr[i] );
align_free( inptr[i] );
}
} // cl_mem flags
return total_errors;
Expand Down
Loading