remove the OpenCL extension specification#1516
Conversation
|
@oddhack would you mind giving these changes a quick review? We're aiming to merge in the OpenCL teleconference next week, on January 27th. Thanks! |
| OpenCL extensions approved by the OpenCL working group use the following | ||
| naming convention: | ||
|
|
||
| * A unique _name string_ of the form `*cl_khr_<__name__>*` or |
There was a problem hiding this comment.
Maybe add a note that exts not approved by the WG are still found separately?
There was a problem hiding this comment.
Good idea, I added a note to the section about vendor extension conventions:
Vendor extensions are not currently included in the OpenCL specifications, but vendor extension specifications are frequently included in the online Registry of extensions.
| The following convention should be followed for all extensions affecting the | ||
| host API: | ||
|
|
||
| [source,opencl] |
There was a problem hiding this comment.
Are you not generating vendor extension interfaces for the headers? I thought all that stuff was in the XML already but haven't looked in quite a while.
There was a problem hiding this comment.
We are, but it doesn't look like we include any information about the XML file in the spec, currently.
I'm open to adding this, but I would prefer to do so in a separate PR.
There was a problem hiding this comment.
For reference, for Vulkan we consider the XML to be a normative part of the spec (hard not to, since a substantial amount of the spec is generated from the XML), but the exact XML schema / toolchain are documented separately in the RNC schema and in a separate https://registry.khronos.org/vulkan/specs/latest/registry.html human-readable description of the schema. So in the spec we just point to the registry.html and mention the XML occasionally as a source of truth, but little more.
| clGetExtensionFunctionAddressForPlatform - Returns the address of the extension function named by _funcname_ for a given _platform_. | ||
|
|
||
| == C Specification | ||
| == Specification |
There was a problem hiding this comment.
Could this be integrated in a refpage block in the API spec, along with the extensions?
There was a problem hiding this comment.
Good idea, done! Since the page is auto-generated now, I've removed the static page.
oddhack
left a comment
There was a problem hiding this comment.
LGTM. Minor suggestions for folding in additional stuff to the API spec.
|
I think all of the review comments have been addressed, so I am going to go ahead and merge this. We can always make additional changes later. Thanks! |
fixes #437
fixes #1111
Moves the remaining content in the OpenCL extension specification into the main OpenCL API specification and the OpenCL C specification and removes the standalone OpenCL extension specification from the spec toolchain. Also updates the OpenCL reference pages and removes remaining links to the OpenCL extension specification.
Specifically: