Revert per-config samples install directories#113
Merged
bashbaug merged 2 commits intoKhronosGroup:mainfrom Oct 11, 2024
Merged
Conversation
This reverts the changes made on KhronosGroup#88 that modified the install location of the samples
Member
Author
|
@bashbaug fyi: agreed with @MathiasMagnus to split the TODO work for SDK and Layers |
Member
Author
|
@bashbaug No further work is needed AFAIK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes made in #88 in which the install directories of the samples were modified to per-config install directories inside the
binfolder.Additionally, the MacOS CI job has been patched as it seems that the install directory of PoCL has changed (from
/opt/homebrew/Cellar/pocl/6.0to/opt/homebrew/Cellar/pocl/6.0_1) and thus the hard-coded vendors path used within the workflow was outdated (and triggering tests failures).