Skip to content

Fixes bug with matrix decomposition and animations #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UX3D-haertl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes bug with matrix decomposition and animations #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/gltf/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ class gltfNode extends GltfObject {
}

getLocalTransform() {
// Matrices are never animated, so if a matrix is present we can just use it directly
if (this.matrix !== undefined) {
return this.matrix;
}
return mat4.fromRotationTranslationScale(
mat4.create(),
this.rotation,
Expand Down