refactor: centralize the retrograde symbol definition into a new constant#20
Open
2mx wants to merge 2 commits intoKibo:masterfrom
Open
refactor: centralize the retrograde symbol definition into a new constant#202mx wants to merge 2 commits intoKibo:masterfrom
2mx wants to merge 2 commits intoKibo:masterfrom
Conversation
…L_CODE` for improved clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change will allow the user to specify which retrograde symbol they want to use.
Changes Made
Added POINT_RETROGRADE_SYMBOL constant in settings
Modified the initialization of the static property SVGUtils.SYMBOL_RETROGRADE_CODE to directly use this constant instead of the letter "M".